fix: errors related to unavailable Snap keyring#8196
Open
Conversation
ccharly
reviewed
Mar 12, 2026
Comment on lines
+86
to
+91
| const keyrings = this.#messenger.call( | ||
| 'KeyringController:getKeyringsByType', | ||
| KeyringTypes.snap, | ||
| ); | ||
|
|
||
| return Array.isArray(keyrings) && keyrings.length > 0; |
Contributor
There was a problem hiding this comment.
I'd probably just use the KeyringController's state directly like with :getState. So the logic between this method and #waitForSnapKeyringViaStateChange would be pretty similar.
The other reason is because :getKeyringsByType is "deprecated" (even though we're still using it all over the place yes 🙃)
Contributor
Author
There was a problem hiding this comment.
Refactored it now to use getState.
david0xd
force-pushed
the
dd/fix-snap-keyring-errors
branch
from
cd583e6 to
a406552
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
hmalik88
reviewed
Mar 16, 2026
david0xd
force-pushed
the
dd/fix-snap-keyring-errors
branch
from
f0f219a to
ddb6c65
Compare
david0xd
force-pushed
the
dd/fix-snap-keyring-errors
branch
from
ddb6c65 to
020aa05
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a fix for errors appearing in the background console when Snap keyring is not yet available. Waiting mechanism is added for the Snap keyring to become available and ready for use.
References
Fixes: MetaMask/metamask-extension#40543
Checklist
Note
Medium Risk
Adds new waiting/timeout logic around Snap platform readiness and Snap keyring availability, which can affect non-EVM account creation timing and introduce new timeout failure modes if misconfigured.
Overview
Fixes non-EVM account creation failures after wallet reset/restore by extending
SnapPlatformWatcher.ensureCanUseSnapPlatform()to also wait for the Snap keyring to exist (viaKeyringController:getStateandKeyringController:stateChange) before proceeding, with explicit timeout errors.Introduces configurable watcher timeouts (
config.snapWatcher.timeoutMs) and adds tests/mocks (includingMOCK_SNAP_KEYRING) covering keyring-appearance, getState-error, and timeout scenarios; updates changelog accordingly.Written by Cursor Bugbot for commit a336710. This will update automatically on new commits. Configure here.